Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix brokenness post the bump to ethereumjs #42

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Fix brokenness post the bump to ethereumjs #42

merged 1 commit into from
Aug 17, 2024

Conversation

cd1m0
Copy link
Collaborator

@cd1m0 cd1m0 commented Aug 17, 2024

  • Remove remaining internal requires;
  • Copy some utility functions to local code from ethereumjs monorepo;
  • Change the interposing on the EVM class from the Interpreter class

@cd1m0
Remove remaining internal requires; Copy some utility functions to lo…
85c2e89 
…cal code; Change the interposing on the EVM class from the Interpreter class
@cd1m0 cd1m0 merged commit cd3c399 into main Aug 17, 2024
2 checks passed
@cd1m0 cd1m0 deleted the remove_requires branch August 17, 2024 02:57
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.58559% with 16 lines in your changes missing coverage. Please review.

Project coverage is 78.73%. Comparing base (92949b1) to head (85c2e89).
Report is 14 commits behind head on main.

Files Patch % Lines
src/debug/foundry_cheatcodes.ts 78.78% 7 Missing ⚠️
src/utils/ethereumjs_internal/opcodes.ts 81.81% 6 Missing ⚠️
src/debug/opcode_interposing.ts 66.66% 2 Missing ⚠️
src/utils/ethereumjs_internal/exceptions.ts 97.14% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   77.89%   78.73%   +0.83%     
==========================================
  Files          22       26       +4     
  Lines        2199     2267      +68     
  Branches      455      465      +10     
==========================================
+ Hits         1713     1785      +72     
+ Misses        422      413       -9     
- Partials       64       69       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cd1m0 @codecov-commenter